[libvirt] [PATCH] * configura.ac, spec file: firewalld now defaults to enabled, depends on dbus * fixed comment for with_firewalld define * bridge_driver, nwfilter_driver: new dbus filters to get Fire

2012-08-13 Thread Thomas Woerner
--- configure.ac| 11 +++ libvirt.spec.in | 11 +++ src/Makefile.am | 4 ++-- src/network/bridge_driver.c | 46 + src/util/ebtables.c | 35 ++ src/util/iptab

Re: [libvirt] [PATCH] * configura.ac, spec file: firewalld now defaults to enabled, depends on dbus * fixed comment for with_firewalld define * bridge_driver, nwfilter_driver: new dbus filters to get

2012-08-13 Thread Eric Blake
On 08/13/2012 01:23 PM, Thomas Woerner wrote: Subject line was a mess. You forgot a one-line summary followed by a blank line before the actual listing of changes you made. Also, by replying in a thread, it's not clear whether this is a new patch unrelated to the rest of the thread, or a resubmi

Re: [libvirt] [PATCH] * configura.ac, spec file: firewalld now defaults to enabled, depends on dbus * fixed comment for with_firewalld define * bridge_driver, nwfilter_driver: new dbus filters to get

2012-08-13 Thread Laine Stump
On 08/13/2012 03:23 PM, Thomas Woerner wrote: ... Thomas, Sorry, I was on a (very long and involved) surprise phone call when you pinged me on IRC, so our discussion was abruptly cut short, and you were already offline by the time I got back to it. My opinion is that it makes sense if with_firew

Re: [libvirt] [PATCH] * configura.ac, spec file: firewalld now defaults to enabled, depends on dbus * fixed comment for with_firewalld define * bridge_driver, nwfilter_driver: new dbus filters to get

2012-08-14 Thread Daniel P. Berrange
On Mon, Aug 13, 2012 at 04:24:04PM -0400, Laine Stump wrote: > We can then decide at runtime whether or not to actually use the > commands. You had mentioned on IRC the possibility of firewalld starting > up after libvirt, or shutting down while libvirt is still running. The > issue I see with that