Re: [libvirt] [PATCH] [4/6] Add the script hook support to the libvirt daemon

2010-03-29 Thread Daniel Veillard
On Fri, Mar 26, 2010 at 11:00:54AM -0600, Eric Blake wrote: On 03/26/2010 09:44 AM, Daniel Veillard wrote: +/* setup the hooks */ +virHookInitialize(); Shouldn't this check for a return of -1? Somehow, yes, as -1 should only be returned in case of serious errors, not just

[libvirt] [PATCH] [4/6] Add the script hook support to the libvirt daemon

2010-03-26 Thread Daniel Veillard
Add the script hook support to the libvirt daemon It supports 3 kind of probing times, at daemon startup, when the daemon reloads its drivers on SIGHUP and when the daemon exits * daemon/libvirtd.c: daemon hooks for startup, reload and exit diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c

Re: [libvirt] [PATCH] [4/6] Add the script hook support to the libvirt daemon

2010-03-26 Thread Eric Blake
On 03/26/2010 09:44 AM, Daniel Veillard wrote: +/* setup the hooks */ +virHookInitialize(); Shouldn't this check for a return of -1? + /* Disable error func, now logging is setup */ virSetErrorFunc(NULL, virshErrorHandler); +/* + * Call the daemon startup