Re: [libvirt] [PATCH] API: Tweak virDomainOpenGraphics to return fd directly

2014-08-27 Thread Ján Tomko
On 08/27/2014 12:05 AM, Eric Blake wrote: Let's fix this before we bake in a painful API. Since we know that we have exactly one non-negative fd on success, we might as well return the fd directly instead of forcing the user to pass in a pointer. Fix a memory leak I found while reviewing.

[libvirt] [PATCH] API: Tweak virDomainOpenGraphics to return fd directly

2014-08-26 Thread Eric Blake
Let's fix this before we bake in a painful API. Since we know that we have exactly one non-negative fd on success, we might as well return the fd directly instead of forcing the user to pass in a pointer. Fix a memory leak I found while reviewing. * include/libvirt/libvirt.h.in

Re: [libvirt] [PATCH] API: Tweak virDomainOpenGraphics to return fd directly

2014-08-26 Thread Jiri Denemark
On Tue, Aug 26, 2014 at 16:05:44 -0600, Eric Blake wrote: Let's fix this before we bake in a painful API. Since we know that we have exactly one non-negative fd on success, we might as well return the fd directly instead of forcing the user to pass in a pointer. Fix a memory leak I found

Re: [libvirt] [PATCH] API: Tweak virDomainOpenGraphics to return fd directly

2014-08-26 Thread Eric Blake
On 08/26/2014 04:18 PM, Jiri Denemark wrote: On Tue, Aug 26, 2014 at 16:05:44 -0600, Eric Blake wrote: Let's fix this before we bake in a painful API. Since we know that we have exactly one non-negative fd on success, we might as well return the fd directly instead of forcing the user to