Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-03-02 Thread Jim Meyering
Cole Robinson wrote: ... Okay, I rolled these changes and the BridgeInUse changes into one patch (along with Jim's suggestions). I added a helper function SetBridgeName which basically does: if user passed bridge name: verify it doesn't collide else: generate bridge name We call

Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-03-02 Thread Daniel P. Berrange
On Fri, Feb 27, 2009 at 10:57:35AM -0500, Cole Robinson wrote: Daniel P. Berrange wrote: On Mon, Feb 16, 2009 at 06:40:59PM -0500, Cole Robinson wrote: diff --git a/src/network_driver.c b/src/network_driver.c index d750565..d83f902 100644 --- a/src/network_driver.c +++

Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-03-02 Thread Cole Robinson
Jim Meyering wrote: Cole Robinson wrote: ... Okay, I rolled these changes and the BridgeInUse changes into one patch (along with Jim's suggestions). I added a helper function SetBridgeName which basically does: if user passed bridge name: verify it doesn't collide else: generate

Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-02-27 Thread Cole Robinson
Daniel P. Berrange wrote: On Mon, Feb 16, 2009 at 06:40:59PM -0500, Cole Robinson wrote: diff --git a/src/network_driver.c b/src/network_driver.c index d750565..d83f902 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -812,7 +812,12 @@ static int

Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-02-18 Thread Jim Meyering
Cole Robinson crobi...@redhat.com wrote: This is the second part of the fix for rhbz 479622. If we are generating a bridge name for a virtual network, don't collide with any bridge name in a defined network. This patch also generates a bridge name at network define time, if none was passed in

Re: [libvirt] [PATCH] Account for defined networks when generating bridge names

2009-02-17 Thread Daniel P. Berrange
On Mon, Feb 16, 2009 at 06:40:59PM -0500, Cole Robinson wrote: diff --git a/src/network_driver.c b/src/network_driver.c index d750565..d83f902 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -812,7 +812,12 @@ static int networkStartNetworkDaemon(virConnectPtr conn,