Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Dusty Mabe
On Fri, Mar 8, 2013 at 1:50 PM, Eric Blake wrote: > > ACK once this is squashed in, so I pushed it. Thanks again for the > patch, and for persisting with addressing our feedback, even if it took > a while. Thanks Eric and Dan! Dusty -- libvir-list mailing list libvir-list@redhat.com https://ww

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Eric Blake
On 03/07/2013 09:03 AM, Dusty Mabe wrote: > --- The commit message should mention the XML changes being made. I'm modifying it to capture this snippet of your testcase: 12572412 ... > docs/schemas/capability.rng | 10 > src

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Dusty Mabe
On Thu, Mar 7, 2013 at 11:03 AM, Dusty Mabe wrote: > --- > docs/schemas/capability.rng | 10 > src/conf/capabilities.c | 8 +++ > src/conf/capabilities.h | 2 + > src/nodeinfo.c| 58 +++- > src/te

[libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-07 Thread Dusty Mabe
--- docs/schemas/capability.rng | 10 src/conf/capabilities.c | 8 +++ src/conf/capabilities.h | 2 + src/nodeinfo.c| 58 +++- src/test/test_driver.c| 2 +- src/xen/xend_intern

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-07 Thread Daniel P. Berrange
On Thu, Mar 07, 2013 at 12:13:30AM -0500, Dusty Mabe wrote: > On Wed, Mar 6, 2013 at 5:07 PM, Daniel P. Berrange > wrote: > > On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote: > >> > >> +if (numa_available() < 0) { > >> +virReportError(VIR_ERR_INTERNAL_ERROR, > >> +

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-06 Thread Dusty Mabe
On Wed, Mar 6, 2013 at 5:07 PM, Daniel P. Berrange wrote: > On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote: >> >> +if (numa_available() < 0) { >> +virReportError(VIR_ERR_INTERNAL_ERROR, >> + "%s", _("NUMA not supported on this host")); >> +goto

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-06 Thread Daniel P. Berrange
On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote: > --- > docs/schemas/capability.rng | 10 > src/conf/capabilities.c | 8 +++ > src/conf/capabilities.h | 2 + > src/nodeinfo.c| 64 +-

[libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-02-14 Thread Dusty Mabe
Hi, This is a follow up to a previous proposed patch that added NUMA memory and CPU thread siblings information to virsh capabilities outout (https://www.redhat.com/archives/libvir-list/2012-November/msg00449.html) Since in a recent commit the thread siblings information was added (http://libv

[libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-02-14 Thread Dusty Mabe
--- docs/schemas/capability.rng | 10 src/conf/capabilities.c | 8 +++ src/conf/capabilities.h | 2 + src/nodeinfo.c| 64 +- src/test/test_driver.c| 2 +- src/xen/xend_inte