Re: [libvirt] [PATCH] Add TCK script for verifying disk based storage pools

2010-03-04 Thread Daniel P. Berrange
On Wed, Mar 03, 2010 at 11:54:28AM -0700, Eric Blake wrote: > According to Daniel P. Berrange on 3/3/2010 11:46 AM: > > High-level review nits below. However, I still count myself as too > inexperienced to offer either an ACK or NAK on this. > > > This adds a reasonably comprehensive test script

Re: [libvirt] [PATCH] Add TCK script for verifying disk based storage pools

2010-03-04 Thread Jim Meyering
Eric Blake wrote: ... >> +# List of host block devices that the test suite can trash all >> +# data on, for purposes of testing. You have been warned ! > > Indeed! The intrepid souls who run these tests might appreciate a crosscheck. Let them specify more than just a block device name, where it's

Re: [libvirt] [PATCH] Add TCK script for verifying disk based storage pools

2010-03-03 Thread Eric Blake
According to Daniel P. Berrange on 3/3/2010 11:46 AM: High-level review nits below. However, I still count myself as too inexperienced to offer either an ACK or NAK on this. > This adds a reasonably comprehensive test script for working with > disk based storage pools. It checks > > - Prevent

[libvirt] [PATCH] Add TCK script for verifying disk based storage pools

2010-03-03 Thread Daniel P. Berrange
This adds a reasonably comprehensive test script for working with disk based storage pools. It checks - Prevent re-formating an existing partition table (currently missing this check in libvirt) - Formating of a partiton table - Wiping a partition table (currently missing in libvirt) - Crea