Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-07 Thread Teto
I had run the 2 first checks but not the valgrind check.Sorry for the memleak, hopefully you catched it. Thanks for your help through the whole process. Matt 2014-02-06 Michal Privoznik mpriv...@redhat.com: On 06.02.2014 15:51, Teto wrote: These 2 patches should address your points. I've also

Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-06 Thread Teto
These 2 patches should address your points. I've also used VIR_APPEND_ELEMENT in another function (1st patch). At your service should you have any other comment. Matthieu Coudron 2014-02-05 Michal Privoznik mpriv...@redhat.com: On 04.02.2014 10:37, Teto wrote: Hi, The following patch was

Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-06 Thread Michal Privoznik
On 06.02.2014 15:51, Teto wrote: These 2 patches should address your points. I've also used VIR_APPEND_ELEMENT in another function (1st patch). At your service should you have any other comment. Matthieu Coudron snip/ 0001-Replaced-VIR_REALLOC_N-by-VIR_APPEND_ELEMENT-in-virD.patch From

Re: [libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-05 Thread Michal Privoznik
On 04.02.2014 10:37, Teto wrote: Hi, The following patch was generated with format patch checked with syntax-check. It is really short and adds a new function virDomainFSInsert which is called when Qemu driver is requested t attach a filesystem device. Matt

[libvirt] [PATCH] Add filesystem support to Qemu's attach_device

2014-02-04 Thread Teto
Hi, The following patch was generated with format patch checked with syntax-check. It is really short and adds a new function virDomainFSInsert which is called when Qemu driver is requested t attach a filesystem device. Matt From f8c0612c48c06c61199693743d98c251ba4d887e Mon Sep 17 00:00:00 2001