2012/3/19 Daniel P. Berrange
> On Fri, Mar 09, 2012 at 06:55:55PM +0800, Chunyan Liu wrote:
> > diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> > index d5fa64a..5dc29a0 100644
> > --- a/src/libxl/libxl_driver.c
> > +++ b/src/libxl/libxl_driver.c
> > +static int doParseURI(const
On Fri, Mar 09, 2012 at 06:55:55PM +0800, Chunyan Liu wrote:
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index d5fa64a..5dc29a0 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> +static int doParseURI(const char *uri, char **p_hostname, int *p_port)
On 03/16/2012 11:53 AM, Jim Fehlig wrote:
>
> Question for other libvirt devs:
>
> Many of the libxl driver functions use this pattern
> - lock driver
> - vm = virDomainFindByUUID // acquires dom obj lock
> - unlock driver
> - do stuff
> - virDomainObjUnlock
>
> In some cases, "do stuff" re
Jim Fehlig wrote:
>> +static int
>> +libxlDomainMigratePerform3(virDomainPtr dom,
>> +const char *xmlin ATTRIBUTE_UNUSED,
>> +const char *cookiein ATTRIBUTE_UNUSED,
>> +int cookieinlen ATTRIBUTE_UNUSED,
>> +
Chunyan Liu wrote:
>
> 2012/3/15 Jim Fehlig mailto:jfeh...@suse.com>>
>
>
> > +/* Create socket connection to receive migration data */
> > +if (!uri_in) {
> > +hostname = virGetHostname(dconn);
> > +if (hostname == NULL)
> > +goto cleanup;
>
2012/3/15 Jim Fehlig
>
> While testing this patch, I noticed some strange problems wrt concurrent
> operations in the driver. E.g. if I start a migration and then query
> dominfo on the migrating domain, it kills the migration
>
> xen134: # virsh migrate --live sles11sp1-pv xen+ssh://xen142
> er
Chunyan Liu wrote:
> Hi, Jim,
> I made some changes to the patch according to your comments:
> a. support concurrent migrations, add virBitmapPtr for probing migration ports
> b. update doParseURI:
> use virAsprintf instead of strdup and snprintf,
> support migration URI syntax hostname[:port],
Hi, Jim,
I made some changes to the patch according to your comments:
a. support concurrent migrations, add virBitmapPtr for probing migration ports
b. update doParseURI:
use virAsprintf instead of strdup and snprintf,
support migration URI syntax hostname[:port], remove xlmigr scheme
c. drop l
Chunyan Liu wrote:
> "Chun Yan Liu" 3/6/2012 2:29 PM >>>
>
>>> I didn't get a chance to test this yet, but have some initial review
>>> comments.
>>>
>>>
Signed-off-by: Chunyan Liu
---
src/libxl/libxl_driver.c | 617
+
"Chun Yan Liu" 3/6/2012 2:29 PM >>>
>> I didn't get a chance to test this yet, but have some initial review
>> comments.
>>
>>> Signed-off-by: Chunyan Liu
>>> ---
>>> src/libxl/libxl_driver.c | 617
>>> ++
>>> src/libxl/libxl_driver.h | 17 ++-
>
> I didn't get a chance to test this yet, but have some initial review
> comments.
>
>> Signed-off-by: Chunyan Liu
>> ---
>> src/libxl/libxl_driver.c | 617
>> ++
>> src/libxl/libxl_driver.h | 17 ++-
>> 2 files changed, 632 insertions(+), 2 deletion
Chunyan Liu wrote:
> Add migration APIs for libxl driver.
> Implemented in migration version 3. Based on xen 4.1.
>
I didn't get a chance to test this yet, but have some initial review
comments.
> Signed-off-by: Chunyan Liu
> ---
> src/libxl/libxl_driver.c | 617
>
Add migration APIs for libxl driver.
Implemented in migration version 3. Based on xen 4.1.
Signed-off-by: Chunyan Liu
---
src/libxl/libxl_driver.c | 617 ++
src/libxl/libxl_driver.h | 17 ++-
2 files changed, 632 insertions(+), 2 deletions(-)
diff
13 matches
Mail list logo