Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-30 Thread D. Herrendoerfer
Thank you for picking this up ! I've got a question: I want to change the link device's MAC address prior to starting the VM, and I want to re-set the MAC to it's original value afterwards. Setting the MAC in the IF is no issue, but is it ok if I add a MAC variable to the direct structure in vi

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-18 Thread Eric Blake
On 05/18/2011 05:32 AM, D. Herrendoerfer wrote: destination device is in private mode. + passthru + This feature allows to attach a virtual function of a SRIOV capable >>> >> That patch looks fine to me, ACK, >> The only unresolved uncertainty to me is what

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-18 Thread D. Herrendoerfer
On May 18, 2011, at 10:53 AM, Daniel Veillard wrote: On Tue, May 17, 2011 at 08:19:17PM -0600, Eric Blake wrote: On 05/17/2011 05:26 AM, D. Herrendoerfer wrote: This patch includes the documentation part. The error returned by libvirt when a using an older kernel is imho sufficient to point

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-18 Thread Daniel Veillard
On Tue, May 17, 2011 at 08:19:17PM -0600, Eric Blake wrote: > On 05/17/2011 05:26 AM, D. Herrendoerfer wrote: > > This patch includes the documentation part. > > > > The error returned by libvirt when a using an older kernel > > is imho sufficient to point to the macvtap setup. Apart from that > >

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-17 Thread Eric Blake
On 05/17/2011 05:26 AM, D. Herrendoerfer wrote: > This patch includes the documentation part. > > The error returned by libvirt when a using an older kernel > is imho sufficient to point to the macvtap setup. Apart from that > I doubt that someone will use this feature by chance. But still - I > b

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-17 Thread D. Herrendoerfer
On May 11, 2011, at 12:21 AM, Eric Blake wrote: Missing corresponding documentation in docs/formatdomain.html.in to describe the new mode. What happens if you try to use this mode but you have an older kernel? Do we need to add any sanity checking to give a saner error message than just blin

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-11 Thread Daniel P. Berrange
On Wed, May 11, 2011 at 10:46:55AM -0400, Laine Stump wrote: > On 05/11/2011 08:21 AM, Daniel P. Berrange wrote: > >On Tue, May 10, 2011 at 04:21:29PM -0600, Eric Blake wrote: > >>On 05/10/2011 05:59 AM, D. Herrendoerfer wrote: > >>>Hi all, > >>> > >>>starting with kernel 2.6.38 macvtap supports a

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-11 Thread Laine Stump
On 05/11/2011 08:21 AM, Daniel P. Berrange wrote: On Tue, May 10, 2011 at 04:21:29PM -0600, Eric Blake wrote: On 05/10/2011 05:59 AM, D. Herrendoerfer wrote: Hi all, starting with kernel 2.6.38 macvtap supports a 'passthru' mode for attaching virtual functions of a SRIOV capable network card d

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-11 Thread Daniel P. Berrange
On Tue, May 10, 2011 at 04:21:29PM -0600, Eric Blake wrote: > On 05/10/2011 05:59 AM, D. Herrendoerfer wrote: > > Hi all, > > > > starting with kernel 2.6.38 macvtap supports a 'passthru' mode for > > attaching virtual functions > > of a SRIOV capable network card directly to a VM. > > This patch

Re: [libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-10 Thread Eric Blake
On 05/10/2011 05:59 AM, D. Herrendoerfer wrote: > Hi all, > > starting with kernel 2.6.38 macvtap supports a 'passthru' mode for > attaching virtual functions > of a SRIOV capable network card directly to a VM. > This patch adds the capability to configure such a device. > > Signed-off-by: Dirk H

[libvirt] [PATCH] Add support for 'passthru' mode for direct network interfaces

2011-05-10 Thread D. Herrendoerfer
Hi all, starting with kernel 2.6.38 macvtap supports a 'passthru' mode for attaching virtual functions of a SRIOV capable network card directly to a VM. This patch adds the capability to configure such a device. Signed-off-by: Dirk Herrendoerfer herrendoerfer.name> diff --git a/docs/schemas