Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-19 Thread Eric Blake
On 08/17/2010 11:44 AM, Patrick Dignan wrote: +if (src-product != NULL) { +virBufferVSprintf(buf,product name='%s'/\n, src-product); +} + virBufferAddLit(buf,/source\n); The only change is that these should use virBufferEscapeString since vendor/product strings might

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-17 Thread Daniel P. Berrange
On Mon, Aug 09, 2010 at 02:32:55PM -0500, Patrick Dignan wrote: Somehow the git-send-email patch didn't make it to the mailing list, though my reply to it did...I've attached the patch here, hopefully this one doesn't get flattened. I decided to allow vendor and product to be set

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-17 Thread Patrick Dignan
On 08/17/2010 12:06 PM, Daniel P. Berrange wrote: On Mon, Aug 09, 2010 at 02:32:55PM -0500, Patrick Dignan wrote: Somehow the git-send-email patch didn't make it to the mailing list, though my reply to it did...I've attached the patch here, hopefully this one doesn't get flattened. I decided

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-09 Thread Patrick Dignan
On 08/06/2010 03:16 AM, Daniel P. Berrange wrote: On Thu, Aug 05, 2010 at 11:51:48PM +0200, Matthias Bolte wrote: 2010/8/5 Patrick Dignanpat_dig...@dell.com: On 08/05/2010 07:24 AM, Daniel P. Berrange wrote: On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote: Hi all, I

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-09 Thread Eric Blake
On 08/09/2010 01:32 PM, Patrick Dignan wrote: Somehow the git-send-email patch didn't make it to the mailing list, though my reply to it did...I've attached the patch here, hopefully this one doesn't get flattened. Much nicer. I decided to allow vendor and product to be set independently

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-06 Thread Daniel P. Berrange
On Thu, Aug 05, 2010 at 11:51:48PM +0200, Matthias Bolte wrote: 2010/8/5 Patrick Dignan pat_dig...@dell.com:  On 08/05/2010 07:24 AM, Daniel P. Berrange wrote: On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote:  Hi all, I wrote a patch to add support for listing the

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-05 Thread Daniel P. Berrange
On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote: Hi all, I wrote a patch to add support for listing the Vendor and Model of a storage pool in the storage pool XML. This would allow vendor extensions of specific devices. The patch includes a test for the new attributes

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-05 Thread Patrick Dignan
On 08/05/2010 07:24 AM, Daniel P. Berrange wrote: On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote: Hi all, I wrote a patch to add support for listing the Vendor and Model of a storage pool in the storage pool XML. This would allow vendor extensions of specific devices. The

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-05 Thread Matthias Bolte
2010/8/5 Patrick Dignan pat_dig...@dell.com:  On 08/05/2010 07:24 AM, Daniel P. Berrange wrote: On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote:  Hi all, I wrote a patch to add support for listing the Vendor and Model of a storage pool in the storage pool XML.  This would

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-05 Thread Eric Blake
On 08/05/2010 12:45 PM, Patrick Dignan wrote: diff -Naurb libvirt-0.8.2.orig/docs/schemas/storagepool.rng Ouch - this flattened the whitespace to the point that it makes reviewing harder to do. Could you consider resending, either via 'git send-email' or by attaching the output of 'git

[libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-02 Thread Patrick Dignan
Hi all, I wrote a patch to add support for listing the Vendor and Model of a storage pool in the storage pool XML. This would allow vendor extensions of specific devices. The patch includes a test for the new attributes as well. I'd appreciate some feedback on it, and would like get it

Re: [libvirt] [PATCH] Add support for Vendor and Model in Storage Pool XML

2010-08-02 Thread Daniel Veillard
On Mon, Aug 02, 2010 at 12:44:37PM -0500, Patrick Dignan wrote: Hi all, I wrote a patch to add support for listing the Vendor and Model of a storage pool in the storage pool XML. This would allow vendor extensions of specific devices. The patch includes a test for the new attributes as