[libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
Hi, this is the patch for to support multiple serial ports for Xen driver. The definition for Xen has been introduced in BZ #614004 and this is adding support to libvirt-based tools. The patch was originally written for RHEL-5 and libvirt 0.8.2 (RHEL-5.6) where it has been tested using the virsh

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Paolo Bonzini
On 01/20/2011 12:58 PM, root wrote: +if ((list-type != VIR_CONF_STRING) || (list-str == NULL)) +goto skipport; + I believe this should do xenXMError(VIR_ERR_INTERNAL_ERROR, _(config value %s was malformed), name); goto

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
On 01/20/2011 02:32 PM, Paolo Bonzini wrote: On 01/20/2011 12:58 PM, root wrote: +if ((list-type != VIR_CONF_STRING) || (list-str == NULL)) +goto skipport; + I believe this should do xenXMError(VIR_ERR_INTERNAL_ERROR, _(config

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote: Hi, this is the patch for to support multiple serial ports for Xen driver. The definition for Xen has been introduced in BZ #614004 and this is adding support to libvirt-based tools. The patch was originally written for RHEL-5

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
On 01/20/2011 02:53 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote: Hi, this is the patch for to support multiple serial ports for Xen driver. The definition for Xen has been introduced in BZ #614004 and this is adding support to libvirt-based

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
On 01/20/2011 03:07 PM, Michal Novotny wrote: On 01/20/2011 03:07 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 03:06:11PM +0100, Michal Novotny wrote: On 01/20/2011 02:53 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote: Hi, this is the

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 03:06:11PM +0100, Michal Novotny wrote: On 01/20/2011 02:53 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote: Hi, this is the patch for to support multiple serial ports for Xen driver. The definition for Xen has been

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
On 01/20/2011 03:07 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 03:06:11PM +0100, Michal Novotny wrote: On 01/20/2011 02:53 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote: Hi, this is the patch for to support multiple serial ports for

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 03:07:55PM +0100, Michal Novotny wrote: On 01/20/2011 03:07 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 03:06:11PM +0100, Michal Novotny wrote: On 01/20/2011 02:53 PM, Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 01:20:50PM +0100, Michal Novotny wrote:

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Paolo Bonzini
On 01/20/2011 02:39 PM, Michal Novotny wrote: Well, I'm working on support for serial port configuration as serial = [ /dev/null, /dev/ttyS0, /dev/ttyS1 ] to: 1) pass /dev/null to the guest as /dev/ttyS0 2) pass /dev/ttyS0 to the guest as /dev/ttyS1 3) pass /dev/ttyS1 to the guest as /dev/ttyS2

Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver

2011-01-20 Thread Michal Novotny
PM Subject: Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver On 01/20/2011 02:39 PM, Michal Novotny wrote: Well, I'm working on support for serial port configuration as serial = [ /dev/null, /dev/ttyS0, /dev/ttyS1 ] to: 1) pass /dev/null to the guest as /dev/ttyS0 2