Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-09-01 Thread Shi Lei
On 2018-08-31 at 20:02, Erik Skultety wrote: >On Thu, Aug 30, 2018 at 02:27:05PM +0800, Shi Lei wrote: >> Thanks for your comments. >> But I have several questions, please see below... >> >> On 2018-08-29 at 19:43, Erik Skultety wrote: >> >On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote:

Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-31 Thread Erik Skultety
On Thu, Aug 30, 2018 at 02:27:05PM +0800, Shi Lei wrote: > Thanks for your comments. > But I have several questions, please see below... > > On 2018-08-29 at 19:43, Erik Skultety wrote: > >On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote: > >> This patch adds virNetlinkNewLink for

Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-30 Thread Shi Lei
Thanks for your comments. But I have several questions, please see below... On 2018-08-29 at 19:43, Erik Skultety wrote: >On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote: >> This patch adds virNetlinkNewLink for simplifying virNetDevMacVLanCreate >> and virNetDevBridgeCreate. >> >>

Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-29 Thread Erik Skultety
On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote: > This patch adds virNetlinkNewLink for simplifying virNetDevMacVLanCreate > and virNetDevBridgeCreate. > > Signed-off-by: Shi Lei > --- There are multiple changes happening in this patch so it will need to be split into several patches,

[libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-22 Thread Shi Lei
This patch adds virNetlinkNewLink for simplifying virNetDevMacVLanCreate and virNetDevBridgeCreate. Signed-off-by: Shi Lei --- src/libvirt_private.syms| 1 + src/util/virnetdevbridge.c | 73 +++ src/util/virnetdevmacvlan.c | 137