Re: [libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-14 Thread Ruben Kerkhof
On Wed, Aug 14, 2013 at 1:35 AM, Eric Blake ebl...@redhat.com wrote: Pushed the fix in your name, along with another line with the same problem (unable chdir(%s), and wrapping some long lines: From 11cdc424d30b15c6780d546a2f0d8ff93ce291b6 Mon Sep 17 00:00:00 2001 From: Ruben Kerkhof

[libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-13 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Address a number of code, style and docs issues identified in review of virt-login-shell after it was merged. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tools/Makefile.am | 1 - tools/virt-login-shell.c | 58

Re: [libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-13 Thread Eric Blake
On 08/13/2013 05:16 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Address a number of code, style and docs issues identified in review of virt-login-shell after it was merged. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tools/Makefile.am

Re: [libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-13 Thread Ruben Kerkhof
On Tue, Aug 13, 2013 at 1:16 PM, Daniel P. Berrange berra...@redhat.comwrote: virReportSystemError(errno, _(Unable exec shell %s), shargv[0]); s/Unable/Unable to/ Kind regards, Ruben -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Address missed feedback from review of virt-login-shell

2013-08-13 Thread Eric Blake
On 08/13/2013 12:09 PM, Ruben Kerkhof wrote: On Tue, Aug 13, 2013 at 1:16 PM, Daniel P. Berrange berra...@redhat.comwrote: virReportSystemError(errno, _(Unable exec shell %s), shargv[0]); s/Unable/Unable to/ Pushed the fix in your name, along with another line with the same problem