Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Cole Robinson
On 05/03/2016 01:52 PM, Nishith Shah wrote: > On Tue, May 3, 2016 at 11:17 PM, Cole Robinson > wrote: > > On 05/03/2016 10:09 AM, Nishith Shah wrote: > > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > > no

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Nishith Shah
On Tue, May 3, 2016 at 11:17 PM, Cole Robinson wrote: > On 05/03/2016 10:09 AM, Nishith Shah wrote: > > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > > no need to pass values in raw bytes, which is seldom the case. > > Also, on v2, you can add

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Cole Robinson
On 05/03/2016 10:09 AM, Nishith Shah wrote: > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > no need to pass values in raw bytes, which is seldom the case. Also, on v2, you can add this bug link to the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=885380

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Ján Tomko
On Tue, May 03, 2016 at 08:18:41PM +0530, Nishith Shah wrote: > On Tue, May 3, 2016 at 8:00 PM, Peter Krempa wrote: > > > On Tue, May 03, 2016 at 14:09:42 +, Nishith Shah wrote: > > > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > > > no need

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Nishith Shah
On Tue, May 3, 2016 at 8:00 PM, Peter Krempa wrote: > On Tue, May 03, 2016 at 14:09:42 +, Nishith Shah wrote: > > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > > no need to pass values in raw bytes, which is seldom the case. > > A change like

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Peter Krempa
On Tue, May 03, 2016 at 14:09:42 +, Nishith Shah wrote: > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is > no need to pass values in raw bytes, which is seldom the case. A change like this is incomplete without adding documentation to the virsh man page

[libvirt] [PATCH] Allow blkdeviotune to take human readable values

2016-05-03 Thread Nishith Shah
Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is no need to pass values in raw bytes, which is seldom the case. --- tools/virsh-domain.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c