Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-11 Thread Eric Blake
On 02/10/2011 07:38 AM, Matthias Bolte wrote: > I get errors like this related to %lld in format strings: > > virsh.c: In function 'cmdDomblkstat': > virsh.c:990:9: warning: unknown conversion type character 'l' in > format [-Wformat] > > The problem goes away when I replace the define for vshPri

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 03:38:08PM +0100, Matthias Bolte wrote: > 2011/2/10 Daniel P. Berrange : > > On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: > >> 2011/2/10 Daniel P. Berrange : > >> > Win32 doesn't have a concept of signal masks so disable that > >> > code. It is unclear how

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Matthias Bolte
2011/2/10 Daniel P. Berrange : > On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: >> 2011/2/10 Daniel P. Berrange : >> > Win32 doesn't have a concept of signal masks so disable that >> > code. It is unclear how SIGINT is delivered (if at all) on >> > Win32, so this might further work

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: > 2011/2/10 Daniel P. Berrange : > > Win32 doesn't have a concept of signal masks so disable that > > code. It is unclear how SIGINT is delivered (if at all) on > > Win32, so this might further work to provide an alternative > > to pth

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Matthias Bolte
2011/2/10 Daniel P. Berrange : > Win32 doesn't have a concept of signal masks so disable that > code. It is unclear how SIGINT is delivered (if at all) on > Win32, so this might further work to provide an alternative > to pthread_sigmask > > * tools/virsh.c: Avoid pthread_sigmask on Win32 > --- AC

[libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an alternative to pthread_sigmask * tools/virsh.c: Avoid pthread_sigmask on Win32 --- tools/virsh.c | 20 +++- 1 f