Re: [libvirt] [PATCH] Better error reporting in qemu AttachDevice

2009-03-02 Thread Daniel P. Berrange
On Fri, Feb 27, 2009 at 11:17:58AM -0500, Cole Robinson wrote: The attached patch fixes qemu AttachDevice to show the invalid disk bus or type in it's error messages. This also adds an error message where previously we could fall through, leading virsh to print 'Unknown Error' if attempting to

Re: [libvirt] [PATCH] Better error reporting in qemu AttachDevice

2009-03-02 Thread Jim Meyering
Cole Robinson wrote: The attached patch fixes qemu AttachDevice to show the invalid disk bus or type in it's error messages. This also adds an error message where previously we could fall through, leading virsh to print 'Unknown Error' if attempting to hotplug an IDE disk. definite

Re: [libvirt] [PATCH] Better error reporting in qemu AttachDevice

2009-03-02 Thread Cole Robinson
Cole Robinson wrote: The attached patch fixes qemu AttachDevice to show the invalid disk bus or type in it's error messages. This also adds an error message where previously we could fall through, leading virsh to print 'Unknown Error' if attempting to hotplug an IDE disk. Committed now.

[libvirt] [PATCH] Better error reporting in qemu AttachDevice

2009-02-27 Thread Cole Robinson
The attached patch fixes qemu AttachDevice to show the invalid disk bus or type in it's error messages. This also adds an error message where previously we could fall through, leading virsh to print 'Unknown Error' if attempting to hotplug an IDE disk. Thanks, Cole commit