Re: [libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-21 Thread Eric Blake
That's a long subject line; I shortened it to: qemu: don't release network actual device twice On 11/16/2011 07:34 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > For direct attach devices, in qemuBuildCommandLine, we seem to be freeing > actual device on error path (with networkReleaseActualD

Re: [libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-21 Thread Stefan Berger
On 11/16/2011 09:34 PM, Roopa Prabhu wrote: From: Roopa Prabhu For direct attach devices, in qemuBuildCommandLine, we seem to be freeing actual device on error path (with networkReleaseActualDevice). But the actual device is not deleted. qemuProcessStop eventually deletes the direct attach devi

[libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error

2011-11-16 Thread Roopa Prabhu
From: Roopa Prabhu For direct attach devices, in qemuBuildCommandLine, we seem to be freeing actual device on error path (with networkReleaseActualDevice). But the actual device is not deleted. qemuProcessStop eventually deletes the direct attach device and releases actual device. But by the ti