Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-11 Thread Dave Allan
On Thu, Aug 11, 2011 at 04:06:59PM +0200, Philipp Hahn wrote: > Hello, > > On Thursday 11 August 2011 08:35:25 Philipp Hahn wrote: > > While testing it I noticed the following behaviour: > > 1. Start virsh > > 2. Do "qemu-monitor-command $SOME_VM info\ chardev" to get the path of the > > pty used

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-11 Thread Philipp Hahn
Hello, On Thursday 11 August 2011 08:35:25 Philipp Hahn wrote: > While testing it I noticed the following behaviour: > 1. Start virsh > 2. Do "qemu-monitor-command $SOME_VM info\ chardev" to get the path of the > pty used for the console → /dev/pts/Y > 3. Execute "console $SOME_VM" from within the

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-10 Thread Philipp Hahn
Hello, On Wednesday 10 August 2011 17:25:58 Eric Blake wrote: > On 08/10/2011 09:09 AM, Dave Allan wrote: > > On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote: > >> --- > >> tools/console.c |2 +- > >> > >> -if (con->stdinWatch != -1) > >> +if (con->stdoutWatch != -1)

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-10 Thread Eric Blake
On 08/10/2011 09:09 AM, Dave Allan wrote: On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote: --- tools/console.c |2 +- -if (con->stdinWatch != -1) +if (con->stdoutWatch != -1) virEventRemoveHandle(con->stdoutWatch); con->stdinWatch = -1; con->

Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-10 Thread Dave Allan
On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote: > --- > tools/console.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/console.c b/tools/console.c > index 11087e5..171ebc9 100644 > --- a/tools/console.c > +++ b/tools/console.c > @@ -95,7 +95,

[libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

2011-08-10 Thread Juerg Haefliger
--- tools/console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/console.c b/tools/console.c index 11087e5..171ebc9 100644 --- a/tools/console.c +++ b/tools/console.c @@ -95,7 +95,7 @@ virConsoleShutdown(virConsolePtr con) virStreamFree(con->st); if