On 03/04/2010 05:54 PM, Cole Robinson wrote:
A few of us talked offline, and decided we should commit this patch as
is for
the release. Dan's proposed change is just a cleanup which can wait, and the
patch fixes a regression when building pools with virt-manager, so I've just
pushed it.
Thanks,
On 03/02/2010 09:51 AM, Laine Stump wrote:
> On 03/02/2010 05:48 AM, Daniel P. Berrange wrote:
>> On Tue, Mar 02, 2010 at 02:17:59AM -0500, Laine Stump wrote:
>>
>>> +uid_t uid = (vol->target.perms.uid == -1) ? getuid() :
>>> vol->target.perms.uid;
>>> +gid_t gid = (vol->target.perms.gid
On 03/02/2010 05:48 AM, Daniel P. Berrange wrote:
On Tue, Mar 02, 2010 at 02:17:59AM -0500, Laine Stump wrote:
+uid_t uid = (vol->target.perms.uid == -1) ? getuid() :
vol->target.perms.uid;
+gid_t gid = (vol->target.perms.gid == -1) ? getgid() :
vol->target.perms.gid;
This s
On Tue, Mar 02, 2010 at 02:17:59AM -0500, Laine Stump wrote:
> This allows the config to have a setting that means "leave it alone",
> eg when building a pool where the directory already exists the user
> may want the current uid/gid of the directory left intact. This
> actually gets us back to old
This allows the config to have a setting that means "leave it alone",
eg when building a pool where the directory already exists the user
may want the current uid/gid of the directory left intact. This
actually gets us back to older behavior - before recent changes to the
pool building code, we wer
