Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-18 Thread Daniel Veillard
On Thu, Mar 04, 2010 at 03:36:26PM +0100, Daniel Veillard wrote: Original bug is: https://bugzilla.redhat.com/show_bug.cgi?id=547514 maybe this could be done in slightly different way, possibly more generic, but I think doing a simple split is good enough for now. Change logrotate

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-12 Thread Dave Allan
On 03/11/2010 01:33 AM, Osier Yang wrote: hi will it be better provide some configuration in libvirtd.conf or ENV viriable to control the log level of each hypervisor log seperately? such as I want to libvirt will just log errors for lxc, but any messages for qemu, warning, and error message

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-11 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 02:33:48PM +0800, Osier Yang wrote: hi will it be better provide some configuration in libvirtd.conf or ENV viriable to control the log level of each hypervisor log seperately? such as I want to libvirt will just log errors for lxc, but any messages for qemu,

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-11 Thread Osier Yang
hmmm, obviously I made a mistake. thanks. osier Daniel Veillard wrote: On Thu, Mar 11, 2010 at 02:33:48PM +0800, Osier Yang wrote: hi will it be better provide some configuration in libvirtd.conf or ENV viriable to control the log level of each hypervisor log seperately? such as I

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-10 Thread Daniel Veillard
On Thu, Mar 04, 2010 at 08:21:05AM -0700, Eric Blake wrote: According to Daniel Veillard on 3/4/2010 7:36 AM: Original bug is: https://bugzilla.redhat.com/show_bug.cgi?id=547514 maybe this could be done in slightly different way, possibly more generic, but I think doing a simple

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-10 Thread Eric Blake
On 03/10/2010 03:29 AM, Daniel Veillard wrote: It would probably be better to write: -e 's...@]localstatedir[@]!$(localstatedir)!g' \ as the substitution. Other than that, you have my ACK Okay, I was afraid at first that the quoting of the expression would defeat make

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-10 Thread Osier Yang
hi will it be better provide some configuration in libvirtd.conf or ENV viriable to control the log level of each hypervisor log seperately? such as I want to libvirt will just log errors for lxc, but any messages for qemu, warning, and error message for uml. Regards osier Daniel

[libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-04 Thread Daniel Veillard
Original bug is: https://bugzilla.redhat.com/show_bug.cgi?id=547514 maybe this could be done in slightly different way, possibly more generic, but I think doing a simple split is good enough for now. Change logrotate to be per-hypervisor logs Having a single logrotate configuration file for

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-04 Thread Eric Blake
According to Daniel Veillard on 3/4/2010 7:36 AM: Original bug is: https://bugzilla.redhat.com/show_bug.cgi?id=547514 maybe this could be done in slightly different way, possibly more generic, but I think doing a simple split is good enough for now. Seems easy enough. +++