Re: [libvirt] [PATCH] Check for private symbols presence as well

2012-10-05 Thread Eric Blake
On 10/05/2012 08:42 AM, Eric Blake wrote: > On 10/05/2012 07:05 AM, Michal Privoznik wrote: >> Currently, we are checking if libvirt.so contains public symbols. >> However, sometimes we rename an internal symbol and forget to >> change libvirt_private.syms accordingly. Hence, it's safer to check >>

Re: [libvirt] [PATCH] Check for private symbols presence as well

2012-10-05 Thread Eric Blake
On 10/05/2012 07:05 AM, Michal Privoznik wrote: > Currently, we are checking if libvirt.so contains public symbols. > However, sometimes we rename an internal symbol and forget to > change libvirt_private.syms accordingly. Hence, it's safer to check > for internal symbols as well. > --- > src/Make

Re: [libvirt] [PATCH] Check for private symbols presence as well

2012-10-05 Thread Michal Privoznik
On 05.10.2012 15:13, Eric Blake wrote: > On 10/05/2012 07:05 AM, Michal Privoznik wrote: >> Currently, we are checking if libvirt.so contains public symbols. >> However, sometimes we rename an internal symbol and forget to >> change libvirt_private.syms accordingly. Hence, it's safer to check >> fo

Re: [libvirt] [PATCH] Check for private symbols presence as well

2012-10-05 Thread Eric Blake
On 10/05/2012 07:05 AM, Michal Privoznik wrote: > Currently, we are checking if libvirt.so contains public symbols. > However, sometimes we rename an internal symbol and forget to > change libvirt_private.syms accordingly. Hence, it's safer to check > for internal symbols as well. > --- > src/Make

[libvirt] [PATCH] Check for private symbols presence as well

2012-10-05 Thread Michal Privoznik
Currently, we are checking if libvirt.so contains public symbols. However, sometimes we rename an internal symbol and forget to change libvirt_private.syms accordingly. Hence, it's safer to check for internal symbols as well. --- src/Makefile.am |7 ++- src/check-symfile.pl |2 +-