Re: [libvirt] [PATCH] Convert dhcpStartDhcpDaemon from virRun to virCommand

2010-12-10 Thread Daniel P. Berrange
On Fri, Dec 10, 2010 at 01:34:15PM -0700, Eric Blake wrote: > On 12/10/2010 12:02 PM, Laine Stump wrote: > > This is pretty straightforward - even though dnsmasq gets daemonized > > and uses a pid file, those things are both handled by the dnsmasq > > binary itself. And libvirt doesn't need any of

Re: [libvirt] [PATCH] Convert dhcpStartDhcpDaemon from virRun to virCommand

2010-12-10 Thread Laine Stump
On 12/10/2010 03:34 PM, Eric Blake wrote: On 12/10/2010 12:02 PM, Laine Stump wrote: This is pretty straightforward - even though dnsmasq gets daemonized and uses a pid file, those things are both handled by the dnsmasq binary itself. And libvirt doesn't need any of the output of the dnsmasq com

Re: [libvirt] [PATCH] Convert dhcpStartDhcpDaemon from virRun to virCommand

2010-12-10 Thread Eric Blake
On 12/10/2010 01:34 PM, Eric Blake wrote: > On 12/10/2010 12:02 PM, Laine Stump wrote: >> This is pretty straightforward - even though dnsmasq gets daemonized >> and uses a pid file, those things are both handled by the dnsmasq >> binary itself. And libvirt doesn't need any of the output of the >>

Re: [libvirt] [PATCH] Convert dhcpStartDhcpDaemon from virRun to virCommand

2010-12-10 Thread Eric Blake
On 12/10/2010 12:02 PM, Laine Stump wrote: > This is pretty straightforward - even though dnsmasq gets daemonized > and uses a pid file, those things are both handled by the dnsmasq > binary itself. And libvirt doesn't need any of the output of the > dnsmasq command either, so we just setup the arg

[libvirt] [PATCH] Convert dhcpStartDhcpDaemon from virRun to virCommand

2010-12-10 Thread Laine Stump
This is pretty straightforward - even though dnsmasq gets daemonized and uses a pid file, those things are both handled by the dnsmasq binary itself. And libvirt doesn't need any of the output of the dnsmasq command either, so we just setup the args and call virRun(). Mainly it was just a (mostly)