Re: [libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-22 Thread Eric Blake
On 10/21/2010 03:14 PM, Eric Blake wrote: +++ b/src/util/dnsmasq.c @@ -76,23 +76,28 @@ hostsfileFree(dnsmasqHostsfile *hostsfile) static int hostsfileAdd(dnsmasqHostsfile *hostsfile, const char *mac, - const char *ip, + virSocketAddr *ip, const char *name) { + char *ipstr; if (VIR_REALLOC_N(hosts

Re: [libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 03:14:25PM -0600, Eric Blake wrote: > On 10/21/2010 12:21 PM, Daniel P. Berrange wrote: > >Instead of storing the IP address string in virNetwork related > >structs, store the parsed virSocketAddr. This will make it > >easier to add IPv6 support in the future, by letting dri

Re: [libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-21 Thread Eric Blake
On 10/21/2010 12:21 PM, Daniel P. Berrange wrote: Instead of storing the IP address string in virNetwork related structs, store the parsed virSocketAddr. This will make it easier to add IPv6 support in the future, by letting driver code directly check what address family is present * src/conf/ne

[libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-21 Thread Daniel P. Berrange
Instead of storing the IP address string in virNetwork related structs, store the parsed virSocketAddr. This will make it easier to add IPv6 support in the future, by letting driver code directly check what address family is present * src/conf/network_conf.c, src/conf/network_conf.h, src/network