Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-15 Thread Daniel P. Berrange
On Fri, Apr 12, 2013 at 01:31:44PM -0600, Eric Blake wrote: On 04/12/2013 10:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do

Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-15 Thread Daniel P. Berrange
On Mon, Apr 15, 2013 at 12:01:56PM +0100, Daniel P. Berrange wrote: On Fri, Apr 12, 2013 at 01:31:44PM -0600, Eric Blake wrote: On 04/12/2013 10:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this

Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-15 Thread Eric Blake
On 04/13/2013 04:54 AM, SHREE DUTH AWASTHI wrote: Hi Daniel, Thanks a lot for the patch, yes it is working as expected. [Please don't top-post on technical lists] # virsh -c qemu://localhost/system version Compiled against library: libvirt 0.10.2 Using library: libvirt 0.10.2 Using

Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-13 Thread SHREE DUTH AWASTHI
Hi Daniel, Thanks a lot for the patch, yes it is working as expected. # virsh -c qemu://localhost/system version Compiled against library: libvirt 0.10.2 Using library: libvirt 0.10.2 Using API: QEMU 0.10.2 Running hypervisor: QEMU 0.14.1 But can you please clarify my below query. Do we really

[libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would have done. In particular we must disable sec mem for

Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt

2013-04-12 Thread Eric Blake
On 04/12/2013 10:27 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would