Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-26 Thread Jiri Denemark
On Thu, Aug 25, 2011 at 13:30:43 -0600, Eric Blake wrote: On 08/25/2011 01:03 PM, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 21:39:41 +0200, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: Shouldn't

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-25 Thread Jiri Denemark
On Tue, Aug 16, 2011 at 21:39:41 +0200, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: If migration failed on source daemon, the migration is automatically canceled by the daemon itself. Thus we don't need to

[libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-16 Thread Jiri Denemark
If migration failed on source daemon, the migration is automatically canceled by the daemon itself. Thus we don't need to call virDomainMigrateConfirm3(cancelled=1). Calling it doesn't cause any harm but the resulting error message printed in logs may confuse people. --- src/libvirt.c | 41

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-16 Thread Eric Blake
On 08/16/2011 04:44 AM, Jiri Denemark wrote: If migration failed on source daemon, the migration is automatically canceled by the daemon itself. Thus we don't need to call virDomainMigrateConfirm3(cancelled=1). Calling it doesn't cause any harm but the resulting error message printed in logs may

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-16 Thread Jiri Denemark
On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: If migration failed on source daemon, the migration is automatically canceled by the daemon itself. Thus we don't need to call virDomainMigrateConfirm3(cancelled=1). Calling it doesn't