"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
> On Tue, May 20, 2008 at 03:38:01PM +0100, Daniel P. Berrange wrote:
>> So I vote for applying all Cole's patches which do indeed fix a number
>> of memory leaks. Fixing the daemon to correctly serialize errors with
>> a dom/net object can be done l
On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote:
> Cole Robinson wrote:
> > Domain and Net objects were not being cleaned up properly
> > when reporting errors from the remote driver. Attached patch
> > fixes this.
> >
>
> Stupid typo. Correct patch attached.
I've applied this to C
On Tue, May 20, 2008 at 03:38:01PM +0100, Daniel P. Berrange wrote:
> So I vote for applying all Cole's patches which do indeed fix a number
> of memory leaks. Fixing the daemon to correctly serialize errors with
> a dom/net object can be done later unless someone has burning desire
> to tackle it
On Tue, May 20, 2008 at 10:11:57AM -0400, Cole Robinson wrote:
> Richard W.M. Jones wrote:
> > On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote:
> >> I'll try this again from the original unpatched state and try to
> >> figure out exactly what was happening.
> >
> > Do you trigger an
Richard W.M. Jones wrote:
> On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote:
>> I'll try this again from the original unpatched state and try to
>> figure out exactly what was happening.
>
> Do you trigger an error at any point in the testing? You could try
> doing that (eg. try mig
On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote:
> I'll try this again from the original unpatched state and try to
> figure out exactly what was happening.
Do you trigger an error at any point in the testing? You could try
doing that (eg. try migrating a QEMU domain).
Rich.
--
R
Richard W.M. Jones wrote:
> On Tue, May 20, 2008 at 02:39:52PM +0100, Daniel P. Berrange wrote:
>> I'm not entirely convinced yet - the code certainly suggests to me that
>> we need to free these. Only a couple of lines further up we obtain a
>> referenced
>> object
>>
>> /* Get the domain and
On Tue, May 20, 2008 at 02:39:52PM +0100, Daniel P. Berrange wrote:
> I'm not entirely convinced yet - the code certainly suggests to me that
> we need to free these. Only a couple of lines further up we obtain a
> referenced
> object
>
> /* Get the domain and network, if set. */
> dom =
On Tue, May 20, 2008 at 09:32:28AM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote:
> >> On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote:
> >>> diff --git a/src/remote_internal.c b/src/remote_internal.c
> >
Daniel P. Berrange wrote:
> On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote:
>> On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote:
>>> diff --git a/src/remote_internal.c b/src/remote_internal.c
>>> index 51e8eb7..80f6ce6 100644
>>> --- a/src/remote_internal.c
>>> +++
On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote:
> On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote:
> > diff --git a/src/remote_internal.c b/src/remote_internal.c
> > index 51e8eb7..80f6ce6 100644
> > --- a/src/remote_internal.c
> > +++ b/src/remote_internal.c
> > @
On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote:
> diff --git a/src/remote_internal.c b/src/remote_internal.c
> index 51e8eb7..80f6ce6 100644
> --- a/src/remote_internal.c
> +++ b/src/remote_internal.c
> @@ -4606,6 +4606,10 @@ server_error (virConnectPtr conn, remote_error *err)
>
Cole Robinson wrote:
> Domain and Net objects were not being cleaned up properly
> when reporting errors from the remote driver. Attached patch
> fixes this.
>
Stupid typo. Correct patch attached.
- Cole
diff --git a/src/remote_internal.c b/src/remote_internal.c
index 51e8eb7..80f6ce6 100644
--
Domain and Net objects were not being cleaned up properly
when reporting errors from the remote driver. Attached patch
fixes this.
Thanks,
Cole
diff --git a/src/remote_internal.c b/src/remote_internal.c
index 51e8eb7..80f6ce6 100644
--- a/src/remote_internal.c
+++ b/src/remote_internal.c
@@ -4606,
14 matches
Mail list logo
