Re: [libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-17 Thread Eric Benner
My mistake I sent it with a mail client and had thought I had all the issues worked out, guess not. I resubmitted it with when I could SMTP. Was going to post the patch here again, but my last email didn't thread properly so I'm just going to post the link so I'm not posting all over the mailing

Re: [libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-17 Thread ebennerit
From: Eric Benner Sorry I attempted to use a mail client since SMTP wasn't working for me at the time. I cleaned up the commit, I believe this is how it needed to be. Signed-off-by: Eric Benner --- src/storage/storage_backend_logical.c | 8 +++- 1 file changed, 3 insertions(+), 5

Re: [libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-10 Thread Michal Privoznik
On 1/6/20 12:51 AM, ebenner wrote: I'm not entirely sure why Libvirt is checking to see if the target file exists for LVM but it is a problem. Empty volume groups do not appear in /dev. When libvirt starts these pools then fail to autostart because their path does not exist. This is not

[libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-06 Thread ebenner
I'm not entirely sure why Libvirt is checking to see if the target file exists for LVM but it is a problem. Empty volume groups do not appear in /dev. When libvirt starts these pools then fail to autostart because their path does not exist. This is not useful, this is the patch we are running