On Mon, May 18, 2009 at 08:04:18PM +0100, Daniel P. Berrange wrote:
> On Mon, May 18, 2009 at 01:57:48PM -0400, Cole Robinson wrote:
> > Let the underlying driver tell us what it supports. At the moment
> > we are at least erroneously denying floppy eject/insert.
> >
> > Last time I posted this, i
On Mon, May 18, 2009 at 01:57:48PM -0400, Cole Robinson wrote:
> Let the underlying driver tell us what it supports. At the moment
> we are at least erroneously denying floppy eject/insert.
>
> Last time I posted this, it was pointed out that 'type' now needs to
> be properly escaped for use in th
Let the underlying driver tell us what it supports. At the moment
we are at least erroneously denying floppy eject/insert.
Last time I posted this, it was pointed out that 'type' now needs to
be properly escaped for use in the xml: while true, that's a problem
in numerous other places in virsh, so
On Fri, Feb 27, 2009 at 11:14:09AM -0500, Cole Robinson wrote:
> virsh attempts to validate the requested disk type, rather than just let
> the underlying driver do it. This was erroneously denying floppy device
> attaches. Patch attached.
ACK
Daniel
--
|: Red Hat, Engineering, London -o- ht
Daniel P. Berrange wrote:
...
>> Changing how the test driver handles this case
>> won't give a better diagnostic for all the other drivers.
>
> At the same time though you don't want to fill virsh up with a pile of
> different error reporting logic for each & every driver. The fine grained
> error
On Mon, Mar 02, 2009 at 05:29:58PM +0100, Jim Meyering wrote:
> Cole Robinson wrote:
> > Jim Meyering wrote:
> >> Cole Robinson wrote:
> >>> virsh attempts to validate the requested disk type, rather than just let
> >>> the underlying driver do it. This was erroneously denying floppy device
> >>> a
On Mon, Mar 02, 2009 at 11:18:24AM -0500, Cole Robinson wrote:
> Jim Meyering wrote:
> > Cole Robinson wrote:
> >> virsh attempts to validate the requested disk type, rather than just let
> >> the underlying driver do it. This was erroneously denying floppy device
> >> attaches. Patch attached.
> >
Cole Robinson wrote:
> Jim Meyering wrote:
>> Cole Robinson wrote:
>>> virsh attempts to validate the requested disk type, rather than just let
>>> the underlying driver do it. This was erroneously denying floppy device
>>> attaches. Patch attached.
>>
>> Hi Cole,
>> Your patch would do the job.
>>
On Mon, Mar 02, 2009 at 05:06:48PM +0100, Jim Meyering wrote:
> Cole Robinson wrote:
> > virsh attempts to validate the requested disk type, rather than just let
> > the underlying driver do it. This was erroneously denying floppy device
> > attaches. Patch attached.
>
> Hi Cole,
> Your patch woul
Jim Meyering wrote:
> Cole Robinson wrote:
>> virsh attempts to validate the requested disk type, rather than just let
>> the underlying driver do it. This was erroneously denying floppy device
>> attaches. Patch attached.
>
> Hi Cole,
> Your patch would do the job.
> Before:
>
> $ virsh -c tes
Cole Robinson wrote:
> virsh attempts to validate the requested disk type, rather than just let
> the underlying driver do it. This was erroneously denying floppy device
> attaches. Patch attached.
Hi Cole,
Your patch would do the job.
Before:
$ virsh -c test:///default attach-disk 1 s t --type
virsh attempts to validate the requested disk type, rather than just let
the underlying driver do it. This was erroneously denying floppy device
attaches. Patch attached.
Thanks,
Cole
commit 3481061f6ed960269d9b29a4a1380367d557cf37
Author: Cole Robinson
Date: Fri Feb 27 10:47:49 2009 -0500
12 matches
Mail list logo
