On Fri, Feb 18, 2011 at 01:52:03PM -0700, Eric Blake wrote:
> On 02/18/2011 01:49 PM, Guido Günther wrote:
> > On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote:
> > [..snip..]
> >> This might as well be the shorter (and faster):
> >>
> >> virCommandAddArg(cmd, "--conf-file=");
> >>
> >>
On 02/18/2011 01:49 PM, Guido Günther wrote:
> On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote:
> [..snip..]
>> This might as well be the shorter (and faster):
>>
>> virCommandAddArg(cmd, "--conf-file=");
>>
>> now that it is only one argument.
> Like in the attached patch?
ACK; please
On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote:
[..snip..]
> This might as well be the shorter (and faster):
>
> virCommandAddArg(cmd, "--conf-file=");
>
> now that it is only one argument.
Like in the attached patch?
-- Guido
>From 1781c7d690b4b6733e3a06ee3f72367efc9ad342 Mon Sep 1
On 02/18/2011 01:32 PM, Eric Blake wrote:
On 02/18/2011 07:37 AM, Guido Günther wrote:
Hi,
Libvirt currently fails to start with dnsmasq>= 2.56.
since dnsmasq now bails out with empty arguments. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944
for the Debian bug and
http://bugs.deb
On 02/18/2011 11:32 AM, Eric Blake wrote:
Oops - I sent my initial reply without finishing reading your patch.
> ./src/option.c:{"pid-file", 2, 0, 'x'},
But your patch was about conf-file. Thankfully:
./src/option.c:{"conf-file", 2, 0, 'C'},
so the same arguments apply.
> --pid-file
On 02/18/2011 07:37 AM, Guido Günther wrote:
> Hi,
> Libvirt currently fails to start with dnsmasq >= 2.56.
> since dnsmasq now bails out with empty arguments. See
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944
>
> for the Debian bug and
>
> http://bugs.debian.org/cgi-bin/bugreport.
Hi,
Libvirt currently fails to start with dnsmasq >= 2.56.
since dnsmasq now bails out with empty arguments. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944
for the Debian bug and
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589885
for the upstream reasoning.
Tested with 2.55 a