Re: [libvirt] [PATCH] Error out on missing machine type in machine configs

2016-02-25 Thread Ján Tomko
On Wed, Feb 24, 2016 at 02:08:41PM -0500, John Ferlan wrote: > > > On 02/11/2016 07:07 AM, Ján Tomko wrote: > > Commit f1a89a8 allowed parsing configs from /etc/libvirt > > without validating the emulator capabilities. > > > > Check for the presence of os->type.machine even if the > >

Re: [libvirt] [PATCH] Error out on missing machine type in machine configs

2016-02-24 Thread John Ferlan
On 02/11/2016 07:07 AM, Ján Tomko wrote: > Commit f1a89a8 allowed parsing configs from /etc/libvirt > without validating the emulator capabilities. > > Check for the presence of os->type.machine even if the > VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS flag is set, > otherwise the daemon can crash

Re: [libvirt] [PATCH] Error out on missing machine type in machine configs

2016-02-18 Thread John Ferlan
On 02/11/2016 07:07 AM, Ján Tomko wrote: > Commit f1a89a8 allowed parsing configs from /etc/libvirt > without validating the emulator capabilities. > > Check for the presence of os->type.machine even if the > VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS flag is set, > otherwise the daemon can crash

[libvirt] [PATCH] Error out on missing machine type in machine configs

2016-02-11 Thread Ján Tomko
Commit f1a89a8 allowed parsing configs from /etc/libvirt without validating the emulator capabilities. Check for the presence of os->type.machine even if the VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS flag is set, otherwise the daemon can crash on carelessly crafted input in the config directory.