Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-31 Thread Soren Hansen
On 25-08-2010 11:03, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: Any comments on this patch? It seems perfectly reasonable to me to get this in regardless of the outcome of this discussion:

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-31 Thread Daniel P. Berrange
On Wed, Aug 25, 2010 at 11:03:42AM +0200, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: libvirt expects this to default to virGetUserDirectory(geteuid()) + '/.uml'. However, user-mode-linux actually uses the HOME

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-31 Thread Eric Blake
On 08/31/2010 04:37 AM, Daniel P. Berrange wrote: On Wed, Aug 25, 2010 at 11:03:42AM +0200, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: @@ -508,6 +507,7 @@ int umlBuildCommandLine(virConnectPtr conn,

[libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Soren Hansen
uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: libvirt expects this to default to virGetUserDirectory(geteuid()) + '/.uml'. However, user-mode-linux actually uses the HOME environment variable to determine where to look for the uml

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Cole Robinson
On 08/25/2010 05:03 AM, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: libvirt expects this to default to virGetUserDirectory(geteuid()) + '/.uml'. However, user-mode-linux actually uses the HOME environment

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Daniel P. Berrange
On Wed, Aug 25, 2010 at 10:07:45AM -0400, Cole Robinson wrote: On 08/25/2010 05:03 AM, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: libvirt expects this to default to virGetUserDirectory(geteuid()) +

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Soren Hansen
On 25-08-2010 16:07, Cole Robinson wrote: On 08/25/2010 05:03 AM, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: I think this should also solve this long standing fedora/selinux bug:

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Soren Hansen
On 25-08-2010 16:18, Daniel P. Berrange wrote: Almost. We still need to change 'driver-monitorDir' so that it gets initialized to '$LOCAL_STATE_DIR/lib/libvirt/uml' like we do with QEMU (or $HOME/.libvirt/uml/lib for session mode) I think leaving it as $HOME/.uml is preferable for

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

2010-08-25 Thread Daniel P. Berrange
On Wed, Aug 25, 2010 at 05:56:22PM +0200, Soren Hansen wrote: On 25-08-2010 16:18, Daniel P. Berrange wrote: Almost. We still need to change 'driver-monitorDir' so that it gets initialized to '$LOCAL_STATE_DIR/lib/libvirt/uml' like we do with QEMU (or $HOME/.libvirt/uml/lib for session