Re: [libvirt] [PATCH] Fix SCSI disk unplugging

2010-05-05 Thread Wolfgang Mauerer
Daniel P. Berrange wrote: > On Tue, May 04, 2010 at 05:18:24PM +0200, Wolfgang Mauerer wrote: >> Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO, >> but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility. >> >> Additionally, when the new-style device synt

Re: [libvirt] [PATCH] Fix SCSI disk unplugging

2010-05-04 Thread Daniel P. Berrange
On Tue, May 04, 2010 at 05:18:24PM +0200, Wolfgang Mauerer wrote: > Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO, > but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility. > > Additionally, when the new-style device syntax is used, we do not need to >

[libvirt] [PATCH] Fix SCSI disk unplugging

2010-05-04 Thread Wolfgang Mauerer
Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO, but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility. Additionally, when the new-style device syntax is used, we do not need to check if the PCI address is valid since we don't need it to do the hot-unpl