Re: [libvirt] [PATCH] Fix a virsh edit memory leak

2010-04-30 Thread Laine Stump
On 04/28/2010 04:27 PM, Chris Lalancette wrote: When running virsh edit, we are unlinking and setting the tmp variable to NULL before going to the end of the function, meaning that we never free tmp. Since the exit to the function will always unlink and free tmp, just remove this bit of code

[libvirt] [PATCH] Fix a virsh edit memory leak

2010-04-28 Thread Chris Lalancette
When running virsh edit, we are unlinking and setting the tmp variable to NULL before going to the end of the function, meaning that we never free tmp. Since the exit to the function will always unlink and free tmp, just remove this bit of code and let it get done at the end. Signed-off-by:

Re: [libvirt] [PATCH] Fix a virsh edit memory leak

2010-04-28 Thread Eric Blake
On 04/28/2010 02:27 PM, Chris Lalancette wrote: When running virsh edit, we are unlinking and setting the tmp variable to NULL before going to the end of the function, meaning that we never free tmp. Since the exit to the function will always unlink and free tmp, just remove this bit of code