Re: [libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread Daniel P. Berrange
On Wed, Jan 14, 2009 at 08:27:36PM +0100, Jim Meyering wrote: > John Levon wrote: > > On Wed, Jan 14, 2009 at 10:53:51AM -0800, john.le...@sun.com wrote: > > > >> Fix activeDomainList handling > >> > >> It must be NULLed out after free()ing. > > > > This one is incomplete - I didn't find the bug s

Re: [libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread Daniel P. Berrange
On Wed, Jan 14, 2009 at 10:53:51AM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1231958879 28800 > # Node ID 1fca4b0dd4c6ab3c0030b4986de6fe5cb7c94631 > # Parent 097f5b4497d7ecc5cce14d10559244313d26ce46 > Fix activeDomainList handling > > It must be

Re: [libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread Jim Meyering
John Levon wrote: > On Wed, Jan 14, 2009 at 10:53:51AM -0800, john.le...@sun.com wrote: > >> Fix activeDomainList handling >> >> It must be NULLed out after free()ing. > > This one is incomplete - I didn't find the bug since I have to use > 0...@0.so with LIBVIRT_DEBUG. Annoyingly, Solaris printf

Re: [libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread John Levon
On Wed, Jan 14, 2009 at 10:53:51AM -0800, john.le...@sun.com wrote: > Fix activeDomainList handling > > It must be NULLed out after free()ing. This one is incomplete - I didn't find the bug since I have to use 0...@0.so with LIBVIRT_DEBUG. Annoyingly, Solaris printf requires %s parameters to not

Re: [libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread Jim Meyering
john.le...@sun.com wrote: > Fix activeDomainList handling In your eventual ChangeLog entry, please mention xsWatchList, too. > It must be NULLed out after free()ing. > > Signed-off-by: John Levon > > diff --git a/src/xs_internal.c b/src/xs_internal.c > --- a/src/xs_internal.c > +++ b/src/xs_inte

[libvirt] [PATCH] Fix activeDomainList handling

2009-01-14 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1231958879 28800 # Node ID 1fca4b0dd4c6ab3c0030b4986de6fe5cb7c94631 # Parent 097f5b4497d7ecc5cce14d10559244313d26ce46 Fix activeDomainList handling It must be NULLed out after free()ing. Signed-off-by: John Levon diff --git a/src/xs_interna