Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-09-01 Thread Christophe Fergeau
Hi, On Fri, Aug 29, 2014 at 10:22:33AM -0600, Eric Blake wrote: Sometimes, when a patch is that invasive, I'll do it in two parts - the change with wrong indentation, followed by another patch that is indentation-only. Much easier to review. Ah right, I remember seeing that in the past, I

[libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to '/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already connected This

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Martin Kletzander
On Fri, Aug 29, 2014 at 10:37:21AM +0200, Christophe Fergeau wrote: Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Christophe Fergeau
Hey, On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote: Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see that using '-w' themselves. That toggle should even

Re: [libvirt] [PATCH] Fix connection to already running session libvirtd

2014-08-29 Thread Eric Blake
On 08/29/2014 06:17 AM, Christophe Fergeau wrote: Hey, On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote: Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see