Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-21 Thread Daniel P. Berrange
On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes t

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Cole Robinson
Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes the leaks I could find, as well as > change

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:48:27AM +0100, Richard W.M. Jones wrote: > On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > > Some pieces of libvirt currently assume that the vir*Destroy > > functions will free the passed object upon success. In > > practice none of the current drivers s

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Richard W.M. Jones
On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes t

[libvirt] [PATCH] Fix destroy command memory leaks

2008-05-19 Thread Cole Robinson
Some pieces of libvirt currently assume that the vir*Destroy functions will free the passed object upon success. In practice none of the current drivers seem to do this, resulting in memory leaks. The attached patch fixes the leaks I could find, as well as changes the comments for virDomainDestroy