Re: [libvirt] [PATCH] Fix docs and code disagreements for character devices.

2009-07-11 Thread Cole Robinson
Daniel P. Berrange wrote: > On Wed, Jul 08, 2009 at 05:59:23PM -0400, Cole Robinson wrote: >> The 'pipe' character type wasn't documented. >> TCP uses a element, not >> We weren't doing strict validation for protocol and source mode values. >> >> Signed-off-by: Cole Robinson >> --- >> docs/form

Re: [libvirt] [PATCH] Fix docs and code disagreements for character devices.

2009-07-09 Thread Daniel Veillard
On Wed, Jul 08, 2009 at 05:59:23PM -0400, Cole Robinson wrote: > The 'pipe' character type wasn't documented. > TCP uses a element, not Oops :-) > We weren't doing strict validation for protocol and source mode values. Cool, looks fine, ACK, thanks ! Daniel -- Daniel Veillard |

Re: [libvirt] [PATCH] Fix docs and code disagreements for character devices.

2009-07-09 Thread Daniel P. Berrange
On Wed, Jul 08, 2009 at 05:59:23PM -0400, Cole Robinson wrote: > The 'pipe' character type wasn't documented. > TCP uses a element, not > We weren't doing strict validation for protocol and source mode values. > > Signed-off-by: Cole Robinson > --- > docs/formatdomain.html| 18 ++

[libvirt] [PATCH] Fix docs and code disagreements for character devices.

2009-07-08 Thread Cole Robinson
The 'pipe' character type wasn't documented. TCP uses a element, not We weren't doing strict validation for protocol and source mode values. Signed-off-by: Cole Robinson --- docs/formatdomain.html| 18 +- docs/formatdomain.html.in | 17 - src/domain_conf