On 05/07/2010 09:24 AM, Daniel P. Berrange wrote:
> The cgroups ACL code was only allowing the primary disk image.
> It is possible to chain images together, so we need to search
> for backing stores and add them to the ACL too. Since the ACL
> only handles block devices, we ignore the EINVAL we ge
The cgroups ACL code was only allowing the primary disk image.
It is possible to chain images together, so we need to search
for backing stores and add them to the ACL too. Since the ACL
only handles block devices, we ignore the EINVAL we get from
plain files. In addition it was missing code to tea
On Wed, Apr 28, 2010 at 11:03:42AM -0600, Eric Blake wrote:
> On 04/28/2010 09:27 AM, Daniel P. Berrange wrote:
> > +memset(&meta, 0, sizeof(meta));
> > +
> > +ret = virStorageFileGetMetadata(path, &meta);
> > +
> > +if (path != vm->def->disks[i]->src
On 04/28/2010 09:27 AM, Daniel P. Berrange wrote:
> +memset(&meta, 0, sizeof(meta));
> +
> +ret = virStorageFileGetMetadata(path, &meta);
> +
> +if (path != vm->def->disks[i]->src)
> +VIR_FREE(path);
> +path = NULL;
The cgroups ACL code was only allowing the primary disk image.
It is possible to chain images together, so we need to search
for backing stores and add them to the ACL too. Since the ACL
only handles block devices, we ignore the EINVAL we get from
plain files.
* src/qemu/qemu_driver.c: Allow backi
