Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-19 Thread Daniel Veillard
On Thu, Jun 18, 2009 at 01:25:46PM -0400, Amy Griffis wrote: Taking a second look at the log level code and documentation, there seems to be some confusion around the value of '0'. It's not one of the defined log priorities, but it is mentioned in the documentation on the website both as

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-18 Thread Amy Griffis
Taking a second look at the log level code and documentation, there seems to be some confusion around the value of '0'. It's not one of the defined log priorities, but it is mentioned in the documentation on the website both as meaning log everything and no logging at all. In the code, there are

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-17 Thread Daniel P. Berrange
On Tue, Jun 16, 2009 at 06:12:04PM -0400, Amy Griffis wrote: Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-17 Thread Amy Griffis
Daniel P. Berrange wrote: [Wed Jun 17 2009, 06:44:31AM EDT] On Tue, Jun 16, 2009 at 06:12:04PM -0400, Amy Griffis wrote: Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it

[libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Amy Griffis
The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API, virLogParseDefaultPriority() along the lines of the other parse functions. Signed-off-by: Amy Griffis

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Cole Robinson
On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API, virLogParseDefaultPriority() along the lines of the other

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Amy Griffis
Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API,

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Cole Robinson
On 06/16/2009 06:12 PM, Amy Griffis wrote: Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I