Re: [libvirt] [PATCH] Fix logical storage pool operation on SLES10-SP2

2008-07-30 Thread Daniel Veillard
On Mon, Jul 28, 2008 at 03:35:30PM -0400, David Lively wrote: > The attached patch adjusts for a difference in behavior in the LVM > utilities 'lvs' and 'vgs'. The SLES10-SP2 versions of these (and > presumably others) append a trailing separator. This patch simply > adjusts the regexps to allow

Re: [libvirt] [PATCH] Fix logical storage pool operation on SLES10-SP2

2008-07-29 Thread David Lively
On Tue, 2008-07-29 at 09:44 +0100, Daniel P. Berrange wrote: > BTW, what version of the LVM tools is SLES using - its probably useful > to note that in the comment you added, in case the same problem is > particular to a version, rather than just SLES lvm2 2.02.17 (-7.19, x86_64) But it's hard t

Re: [libvirt] [PATCH] Fix logical storage pool operation on SLES10-SP2

2008-07-29 Thread Daniel P. Berrange
On Mon, Jul 28, 2008 at 03:35:30PM -0400, David Lively wrote: > The attached patch adjusts for a difference in behavior in the LVM > utilities 'lvs' and 'vgs'. The SLES10-SP2 versions of these (and > presumably others) append a trailing separator. This patch simply > adjusts the regexps to allow

[libvirt] [PATCH] Fix logical storage pool operation on SLES10-SP2

2008-07-28 Thread David Lively
The attached patch adjusts for a difference in behavior in the LVM utilities 'lvs' and 'vgs'. The SLES10-SP2 versions of these (and presumably others) append a trailing separator. This patch simply adjusts the regexps to allow (but not require) this. I thought just adding the ":?" to the regexps