Re: [libvirt] [PATCH] Fix memory leaks in cmdInterfaceEdit and cmdNWFilterEdit.

2010-05-03 Thread Daniel Veillard
On Sat, May 01, 2010 at 12:20:34AM -0400, Laine Stump wrote: This applies a fix to thos functions similar to that made to cmdEdit in 270895063d1cf86ab42fa220a8d090c24d58dbc0, thus fnixing a memory leak - if tmp is unlinked and NULLed early in the function, the memory used by tmp is never

Re: [libvirt] [PATCH] Fix memory leaks in cmdInterfaceEdit and cmdNWFilterEdit.

2010-05-03 Thread Laine Stump
On 05/01/2010 12:57 PM, Eric Blake wrote: ACK. Gotta love leak cleanups by code deletion. Pushed. Thanks! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix memory leaks in cmdInterfaceEdit and cmdNWFilterEdit.

2010-05-01 Thread Eric Blake
On 04/30/2010 10:20 PM, Laine Stump wrote: This applies a fix to thos functions similar to that made to cmdEdit in 270895063d1cf86ab42fa220a8d090c24d58dbc0, thus fnixing a memory leak - if tmp is unlinked and NULLed early in the function, the memory used by tmp is never freed. Since we will

[libvirt] [PATCH] Fix memory leaks in cmdInterfaceEdit and cmdNWFilterEdit.

2010-04-30 Thread Laine Stump
This applies a fix to thos functions similar to that made to cmdEdit in 270895063d1cf86ab42fa220a8d090c24d58dbc0, thus fnixing a memory leak - if tmp is unlinked and NULLed early in the function, the memory used by tmp is never freed. Since we will always unlink tmp prior to freeing its memory at