Re: [libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-26 Thread Daniel Veillard
On Wed, May 18, 2011 at 11:34:36AM +0200, Markus Groß wrote: Am Mittwoch 18 Mai 2011 09:22:43 schrieb Markus Groß: v2: - free dev before using it again. When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets

Re: [libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-18 Thread Markus Groß
v2: - free dev before using it again. When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets dev-data-disk to NULL. Later qemuDomainAttachDeviceLive accesses dev-data.disk and causes a segfault. ---

Re: [libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-18 Thread Wen Congyang
At 05/18/2011 03:22 PM, Markus Groß Write: v2: - free dev before using it again. When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets dev-data-disk to NULL. Later qemuDomainAttachDeviceLive accesses

Re: [libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-18 Thread Markus Groß
Am Mittwoch 18 Mai 2011 09:22:43 schrieb Markus Groß: v2: - free dev before using it again. When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets dev-data-disk to NULL. Later qemuDomainAttachDeviceLive accesses

[libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-11 Thread Markus Groß
When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets dev-data-disk to NULL. Later qemuDomainAttachDeviceLive accesses dev-data.disk and causes a segfault. --- src/qemu/qemu_driver.c | 14 ++ 1 files

Re: [libvirt] [PATCH] Fix modifying disk devices in qemu driver

2011-05-11 Thread Wen Congyang
At 05/11/2011 07:12 PM, Markus Groß Write: When modifying the disk devices of a live domain and the domain configuration, the function qemuDomainAttachDeviceConfig first sets dev-data-disk to NULL. Later qemuDomainAttachDeviceLive accesses dev-data.disk and causes a segfault. ---