Re: [libvirt] [PATCH] Fix performance problem of virStorageVolCreateXMLFrom()

2011-03-08 Thread Minoru Usui
Hi, Daniel. Thank you for your comment. > > @@ -119,8 +126,10 @@ virStorageBackendCopyToFD(virStorageVolDefPtr vol, > > int amtread = -1; > > int ret = 0; > > unsigned long long remain; > > -size_t rbytes = 1024 * 1024; /* For Read */ > > -char zerobuf[512]; > > +size_t

Re: [libvirt] [PATCH] Fix performance problem of virStorageVolCreateXMLFrom()

2011-03-08 Thread Daniel P. Berrange
On Tue, Mar 08, 2011 at 01:01:34PM +0900, Minoru Usui wrote: > virStorageVolCreateXMLFrom() is slow if destination Pool is LVM. > Because write block size is not appropriate. > > On linux environment, block size of LVM Pool which is made by > virStoragePoolCreateXML() > is 4096 bytes. > On the ot

[libvirt] [PATCH] Fix performance problem of virStorageVolCreateXMLFrom()

2011-03-07 Thread Minoru Usui
virStorageVolCreateXMLFrom() is slow if destination Pool is LVM. Because write block size is not appropriate. On linux environment, block size of LVM Pool which is made by virStoragePoolCreateXML() is 4096 bytes. On the other hand, write block size of virStorageVolCreateXMLFrom() is 512 bytes. T