Re: [libvirt] [PATCH] Fix potential false-positive OOM error reporting

2009-10-22 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 10:41:53PM +0200, Matthias Bolte wrote: If no matching device was found (cap == NULL) then no strdup() call was made and *wwnn and *wwpn are untouched. Checking them for NULL in this situation may result in reporting an false-positive OOM error because *wwnn and *wwpn

Re: [libvirt] [PATCH] Fix potential false-positive OOM error reporting

2009-10-22 Thread Cole Robinson
On 10/21/2009 04:41 PM, Matthias Bolte wrote: If no matching device was found (cap == NULL) then no strdup() call was made and *wwnn and *wwpn are untouched. Checking them for NULL in this situation may result in reporting an false-positive OOM error because *wwnn and *wwpn may be initialized

[libvirt] [PATCH] Fix potential false-positive OOM error reporting

2009-10-21 Thread Matthias Bolte
If no matching device was found (cap == NULL) then no strdup() call was made and *wwnn and *wwpn are untouched. Checking them for NULL in this situation may result in reporting an false-positive OOM error because *wwnn and *wwpn may be initialized to NULL by the caller. Only check *wwnn and *wwpn