[libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-16 Thread Jason J. Herne
From: "Jason J. Herne" libvirt_iohelper is a helper process that is exec'ed and used to handle I/O during a Qemu managed save operation. Due to a missing call to virFileWrapperFdClose, all I/O error messages reported by iohelper are lost. This patch adds a call to virFileWrapperFdClose to the cl

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-16 Thread Eric Blake
On 07/16/2014 08:12 AM, Jason J. Herne wrote: > From: "Jason J. Herne" > > libvirt_iohelper is a helper process that is exec'ed and used to handle I/O > during a Qemu managed save operation. Due to a missing call to > virFileWrapperFdClose, all I/O error messages reported by iohelper are lost. >

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-16 Thread Eric Blake
On 07/16/2014 08:30 AM, Eric Blake wrote: > On 07/16/2014 08:12 AM, Jason J. Herne wrote: >> From: "Jason J. Herne" >> >> libvirt_iohelper is a helper process that is exec'ed and used to handle I/O >> during a Qemu managed save operation. Due to a missing call to >> virFileWrapperFdClose, all I/O

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-16 Thread Eric Blake
On 07/16/2014 03:56 PM, Eric Blake wrote: > On 07/16/2014 08:30 AM, Eric Blake wrote: >> On 07/16/2014 08:12 AM, Jason J. Herne wrote: >>> From: "Jason J. Herne" >>> >>> libvirt_iohelper is a helper process that is exec'ed and used to handle I/O >>> during a Qemu managed save operation. Due to a m

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-16 Thread Eric Blake
On 07/16/2014 05:20 PM, Eric Blake wrote: > But if I then rework the iohelper patch: > > diff --git i/src/util/iohelper.c w/src/util/iohelper.c > index 8a3c377..efb1366 100644 > --- i/src/util/iohelper.c > +++ w/src/util/iohelper.c > @@ -301,6 +301,7 @@ main(int argc, char **argv) > exit

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-30 Thread Jason Herne
--| |07/16/2014 07:57 PM | >--| |> | Subject: | |> >------------------------------

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-30 Thread Jason Herne
When I use this patch: diff --git a/src/util/iohelper.c b/src/util/iohelper.c index 8a3c377..255365c 100644 --- a/src/util/iohelper.c +++ b/src/util/iohelper.c @@ -307,6 +307,7 @@ main(int argc, char **argv) if (delete) unlink(path); +fprintf(stderr, _("goodbye world \n")); got

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2015-02-05 Thread Jason J. Herne
Hello Eric, it has been quite a while since we have looked at this :). I'm revisiting this problem and I find that it still exists. Here is an archive link of our previous discussions on this: https://www.redhat.com/archives/libvir-list/2014-July/thread.html#00809 Basically, when I do a migr

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2015-02-18 Thread Jason J. Herne
On 02/05/2015 11:26 AM, Jason J. Herne wrote: Hello Eric, it has been quite a while since we have looked at this :). I'm revisiting this problem and I find that it still exists. Here is an archive link of our previous discussions on this: https://www.redhat.com/archives/libvir-list/2014-July/th