Re: [libvirt] [PATCH] Fix storage pool source comparison to avoid comparing with self

2011-11-01 Thread Guido Günther
Hi Daniel, On Tue, Oct 11, 2011 at 11:26:59AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If we are comparing storage pools we must skip comparing with ourself, so that re-defining an existing pool works * conf/storage_conf.c: Skip self when comparing

Re: [libvirt] [PATCH] Fix storage pool source comparison to avoid comparing with self

2011-11-01 Thread Daniel P. Berrange
On Tue, Nov 01, 2011 at 12:08:58PM +0100, Guido Günther wrote: Hi Daniel, On Tue, Oct 11, 2011 at 11:26:59AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If we are comparing storage pools we must skip comparing with ourself, so that re-defining an

[libvirt] [PATCH] Fix storage pool source comparison to avoid comparing with self

2011-10-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If we are comparing storage pools we must skip comparing with ourself, so that re-defining an existing pool works * conf/storage_conf.c: Skip self when comparing --- src/conf/storage_conf.c |4 1 files changed, 4 insertions(+), 0

Re: [libvirt] [PATCH] Fix storage pool source comparison to avoid comparing with self

2011-10-11 Thread Eric Blake
On 10/11/2011 04:26 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com If we are comparing storage pools we must skip comparing with ourself, so that re-defining an existing pool works * conf/storage_conf.c: Skip self when comparing --- src/conf/storage_conf.c |4