Re: [libvirt] [PATCH] Fix uninitialized variable error reporting in LXC veth setup

2011-03-22 Thread Daniel Veillard
On Mon, Mar 21, 2011 at 03:36:30PM +, Daniel P. Berrange wrote: On Thu, Mar 17, 2011 at 12:46:55PM -0400, Laine Stump wrote: On 03/17/2011 11:57 AM, Daniel P. Berrange wrote: THe veth setup in LXC had a couple of flaws, first brInit did not report any error when it failed. Second

Re: [libvirt] [PATCH] Fix uninitialized variable error reporting in LXC veth setup

2011-03-21 Thread Daniel P. Berrange
On Thu, Mar 17, 2011 at 12:46:55PM -0400, Laine Stump wrote: On 03/17/2011 11:57 AM, Daniel P. Berrange wrote: THe veth setup in LXC had a couple of flaws, first brInit did not report any error when it failed. Second vethCreate() did not correctly initialize the variable containing the return

[libvirt] [PATCH] Fix uninitialized variable error reporting in LXC veth setup

2011-03-17 Thread Daniel P. Berrange
THe veth setup in LXC had a couple of flaws, first brInit did not report any error when it failed. Second vethCreate() did not correctly initialize the variable containing the return code, so could report failure even when it succeeded. * src/lxc/lxc_driver.c: Report error when brInit fails *

Re: [libvirt] [PATCH] Fix uninitialized variable error reporting in LXC veth setup

2011-03-17 Thread Laine Stump
On 03/17/2011 11:57 AM, Daniel P. Berrange wrote: THe veth setup in LXC had a couple of flaws, first brInit did not report any error when it failed. Second vethCreate() did not correctly initialize the variable containing the return code, so could report failure even when it succeeded. *