Re: [libvirt] [PATCH] Fix up connection reference counting.

2009-08-18 Thread Chris Lalancette
Daniel P. Berrange wrote: > > ACK > During testing of this patch, I actually found a small bug, so the final version that I committed is attached. -- Chris Lalancette commit f5cc4a5a696680577eb6b2daaf7521bc5fcfbc5e Author: Chris Lalancette Date: Tue Aug 11 15:48:59 2009 +0200 Fix up co

Re: [libvirt] [PATCH] Fix up connection reference counting.

2009-08-17 Thread Daniel P. Berrange
On Mon, Aug 17, 2009 at 12:57:17PM +0200, Chris Lalancette wrote: > Currently the reference counting for connections is busted. I > first noticed it while trying to use virConnectRef; it would > eventually cause a crash in the remote_internal driver, although > that was really just a victim. Real

[libvirt] [PATCH] Fix up connection reference counting.

2009-08-17 Thread Chris Lalancette
Currently the reference counting for connections is busted. I first noticed it while trying to use virConnectRef; it would eventually cause a crash in the remote_internal driver, although that was really just a victim. Really, we should only call the close callbacks on the methods when the refere

Re: [libvirt] [PATCH] Fix up connection reference counting.

2009-08-13 Thread Daniel P. Berrange
On Thu, Aug 13, 2009 at 10:51:46AM +0200, Chris Lalancette wrote: > Currently the reference counting for connections is busted. I > first noticed it while trying to use virConnectRef; it would > eventually cause a crash in the remote_internal driver, although > that was really just a victim. Real

[libvirt] [PATCH] Fix up connection reference counting.

2009-08-13 Thread Chris Lalancette
Currently the reference counting for connections is busted. I first noticed it while trying to use virConnectRef; it would eventually cause a crash in the remote_internal driver, although that was really just a victim. Really, we should only call the close callbacks on the methods when the refere