Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Cole Robinson wrote: > Jim Meyering wrote: >> Daniel Veillard wrote: >>> On Fri, Jan 16, 2009 at 12:09:33AM +, Daniel P. Berrange wrote: On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > ... >>> + virsh --connect qemu:///session

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Jim Meyering wrote: > Daniel Veillard wrote: >> On Fri, Jan 16, 2009 at 12:09:33AM +, Daniel P. Berrange wrote: >>> On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: "Daniel P. Berrange" wrote: ... >> + virsh --connect qemu:///session define devs.xml > Shouldn'

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Daniel Veillard wrote: > On Fri, Jan 16, 2009 at 12:09:33AM +, Daniel P. Berrange wrote: >> On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: >> > "Daniel P. Berrange" wrote: >> > ... >> > >> + virsh --connect qemu:///session define devs.xml >> > > >> > > Shouldn't use qemu:///s

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Fri, Jan 16, 2009 at 02:37:04PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > On Fri, Jan 16, 2009 at 12:42:35PM +0100, Jim Meyering wrote: > >> "Daniel P. Berrange" wrote: > >> > >> > >> Ah. I'd only run the define, which is enough to make > >> libvirtd fail when using qemu:///

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Jim Meyering wrote: ... > FYI, here's a new version of this latest test. > Now it uses the new unix_sock_dir setting to avoid > risk of interfering with any existing qemu-based settings. > > (this patch depends on the unix_sock_dir-adding patch > that's still waiting for an ACK. Also, I have two

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

"Daniel P. Berrange" wrote: > On Fri, Jan 16, 2009 at 12:42:35PM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" wrote: >> >> > On Fri, Jan 16, 2009 at 09:24:33AM +0100, Jim Meyering wrote: >> >> "Daniel P. Berrange" wrote: >> >> > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote:

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Fri, Jan 16, 2009 at 12:42:35PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > > On Fri, Jan 16, 2009 at 09:24:33AM +0100, Jim Meyering wrote: > >> "Daniel P. Berrange" wrote: > >> > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: > >> >> "Daniel P. Berrange" wrot

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

"Daniel P. Berrange" wrote: > On Fri, Jan 16, 2009 at 09:24:33AM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" wrote: >> > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: >> >> "Daniel P. Berrange" wrote: >> >> ... >> >> >> + virsh --connect qemu:///session define devs.xml

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Fri, Jan 16, 2009 at 09:24:33AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: > >> "Daniel P. Berrange" wrote: > >> ... > >> >> + virsh --connect qemu:///session define devs.xml > >> > > >> > Shouldn't use qemu:///s

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

"Daniel P. Berrange" wrote: > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" wrote: >> ... >> >> + virsh --connect qemu:///session define devs.xml >> > >> > Shouldn't use qemu:///session for test cases like this - this is what >> > the test:///default driv

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Fri, Jan 16, 2009 at 12:09:33AM +, Daniel P. Berrange wrote: > On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: > > "Daniel P. Berrange" wrote: > > ... > > >> + virsh --connect qemu:///session define devs.xml > > > > > > Shouldn't use qemu:///session for test cases like this

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > ... > >> + virsh --connect qemu:///session define devs.xml > > > > Shouldn't use qemu:///session for test cases like this - this is what > > the test:///default driver is for, avoiding the fragility & d

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

"Daniel P. Berrange" wrote: ... >> + virsh --connect qemu:///session define devs.xml > > Shouldn't use qemu:///session for test cases like this - this is what > the test:///default driver is for, avoiding the fragility & danger of > using the daemon & live hypervisor drivers. There's no failure

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

On Thu, Jan 15, 2009 at 07:55:52PM +0100, Jim Meyering wrote: > Cole Robinson wrote: > > If you define a domain with serial devs > 0 && parallel devs >= serial > > devs, libvirtd segfaults when trying to set up the back compat console > > device. We were using a previous loop counter where we shou

Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Cole Robinson wrote: > If you define a domain with serial devs > 0 && parallel devs >= serial > devs, libvirtd segfaults when trying to set up the back compat console > device. We were using a previous loop counter where we shouldn't. The > attached patch fixes this. > > Thanks, > Cole > diff --gi

[libvirt] [PATCH] Fix vm define error with back compat console device

If you define a domain with serial devs > 0 && parallel devs >= serial devs, libvirtd segfaults when trying to set up the back compat console device. We were using a previous loop counter where we shouldn't. The attached patch fixes this. Thanks, Cole diff --git a/src/domain_conf.c b/src/domain_co