Re: [libvirt] [PATCH] Fixes for VNC port handling

2009-01-28 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 09:23:42PM -0800, john.le...@sun.com wrote: Fixes for VNC port handling When parsing sexpr, the VNC port should not be ignored, even when vncunused is set. Fix the parsing of vncdisplay, which was broken due to strtol() (never use this function!). Signed-off-by:

Re: [libvirt] [PATCH] Fixes for VNC port handling

2009-01-28 Thread John Levon
On Wed, Jan 28, 2009 at 11:29:16AM +, Daniel P. Berrange wrote: +device/vfb/vncdisplay); +if (value != NULL) +port = strtol(value, NULL, 0); This isn't checking the return value of strtol, so it could have parsed

[libvirt] [PATCH] Fixes for VNC port handling

2009-01-28 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233162577 28800 # Node ID 6ab030d99574ee01193e92846eb7c9b41bfcd149 # Parent 5a0860d81ed44d5f189788fc340f975517595160 Fixes for VNC port handling When parsing sexpr, the VNC port should not be ignored, even when vncunused is set. Fix the

[libvirt] [PATCH] Fixes for VNC port handling

2009-01-27 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233118371 28800 # Node ID f91041f0c607be72c4b5695f081d20716521f6c5 # Parent 8fce2ce6108eb1ff1865ecc21d57114db036f2a2 Fixes for VNC port handling When parsing sexpr, the VNC port should not be ignored, even when vncunused is set. Fix the